Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscription status type incomplete #86

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

keyding
Copy link
Contributor

@keyding keyding commented Apr 22, 2024

Issue #83.

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: aeba8f5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lemonsqueezy/lemonsqueezy.js Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brankoconjic
Copy link
Collaborator

brankoconjic commented Apr 22, 2024

@keyding, this does not align with the Lemon Squeezy API docs. I will need to check that on our side.

@brankoconjic
Copy link
Collaborator

The incomplete is a valid status, which happens before a subscription has been fulfilled.

@brankoconjic brankoconjic self-requested a review June 11, 2024 16:15
@brankoconjic brankoconjic merged commit 2e9beae into lmsqueezy:main Jun 11, 2024
brankoconjic added a commit that referenced this pull request Jun 12, 2024
brankoconjic added a commit that referenced this pull request Jun 12, 2024
* Revert "Add subscription `status` type `incomplete` (#86)"

This reverts commit 2e9beae.

* docs: add changeset
@keyding keyding deleted the fix/issue-83 branch June 13, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants